[ https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304177#comment-17304177 ]
Stefan Bischof edited comment on SLING-10224 at 3/18/21, 2:18 PM: ------------------------------------------------------------------ I am ready here! No more goals on this. Really optional there could be a test that shows that the substitutions of the [configadmin-plugins|https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md] survive. They look like $[variable] . was (Author: bisch...@jena.de): I am ready here! No more goals on this. Really optional there could be a test that shows that the substitutions that the [configadmin-plugins|https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md] survive. They look like $[variable] . > Feature-Launcher: only embed a minimal set of apache-commons classes > --------------------------------------------------------------------- > > Key: SLING-10224 > URL: https://issues.apache.org/jira/browse/SLING-10224 > Project: Sling > Issue Type: Improvement > Components: Feature Model > Reporter: Stefan Bischof > Priority: Major > > StringSubstitutor from commons-text is a great Util to replace '${thisVar}' > with something. In the SlingFeatureLauncher case it replaces placeholder with > the value of the map`context.getFrameworkProperties()` , or an empty string. > But commons-lang3 and commons-text brings 600kb to the Bundle. > Maybe we can Substitute it with a more lightweight StringSubstitutor. > _Update: as discussed below, embedding just the required apache-commons > classes has the same effect, without having to rewrite code_ -- This message was sent by Atlassian Jira (v8.3.4#803005)