[ 
https://issues.apache.org/jira/browse/SLING-10248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305934#comment-17305934
 ] 

Carsten Ziegeler commented on SLING-10248:
------------------------------------------

Started the refactoring in [1] by letting the listener extend the cache. This 
reduces the coupling between the authenticator and the listener.
I've also fixed the isAnonAllowed test (it was not really testing the code but 
rather the test setup)

[1] 
https://github.com/apache/sling-org-apache-sling-auth-core/commit/de43cb0c16f0de307b3f227ff3c0da2e8057806d

> Refactor: Move auth requirements handling into separate component
> -----------------------------------------------------------------
>
>                 Key: SLING-10248
>                 URL: https://issues.apache.org/jira/browse/SLING-10248
>             Project: Sling
>          Issue Type: Improvement
>          Components: Authentication
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: Auth Core 1.5.2
>
>
> The handling of auth requirements is currently split across three classes, 
> the cache (path based holder), Sling Authenticator (for configuration) and 
> SlingAuthenticatorServiceListener (service registrations)
> We should refactor this into a single class - to make the code cleaner but 
> also easier testable



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to