[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307601#comment-17307601
]
Ashish Chopra commented on SLING-9871:
--------------------------------------
hi [~bdelacretaz],
bq. I think that's the simplest thing to implement and ... solves the problem,
and can apply to any repoinit statements, it's just an aggregation thing that's
not directly related to the language syntax.
My understanding is that the proposal _does_ solve the issue described in this
ticket, and I'm all in favour of simpler implementations!
I believe we'd to document the preprocessing-nature of the fragment-reorder so
that the consumers of this feature are aware that only the statements contained
within the fragments will be applied in a rearranged order - any implications
of that on the final state of the system is not binding on repoinit.
bq. requiring unique fragment names might make things clearer and
troubleshooting simpler (see the FRAGMENTS comment in the output above)
+1.
----
I'd also think fragment-preprocessing and reordering makes the case for an
intermediate, post-processed model to be (optionally) made available for
investigation. This will help the consumers to perform some initial diagnosis
on issues they encounter as they start using this feature.
> Specifying order of ACEs through repoinit directives
> ----------------------------------------------------
>
> Key: SLING-9871
> URL: https://issues.apache.org/jira/browse/SLING-9871
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
> Reporter: Ashish Chopra
> Priority: Major
>
> As of writing this, repoinit processor (among other things not relevant to
> this JIRA) collects {{create path}} statements and {{set ACL}} statements
> declared in all the feature-models applicable to feature-aggregate under
> consideration.
> Upon repository initialization, it applies all the {{create path}}
> statements, followed by all the {{set ACL}} statements. However, the order in
> which {{set ACL}} statements declared across feature models are applied isn't
> defined (currently, it seems to be based on feature-model-name,
> alphabetically ascending).
> This causes issues at times because we want the order of the ACEs to be
> maintained (e.g., "deny"s for everyone at a given path must be the first ACE,
> followed by "allow"s for specific, non-system-user principals)
> Repoinit should be able to support this requirement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
