kwin commented on pull request #70:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818556608


   @karlpauls `dropContent` is only an internal flag and can imho be renamed to 
reflect that this is only about not referencing it in the feature model. What 
matters is IMHO the CLI option which is named 
`--include-content-type-packages`. I am fine with outputting the artifacts not 
refenced in the feature model in a dedicated output folder, but I still don't 
see the need to two CLI options or more than the boolean toggle 
`--include-content-type-packages`. Again, `dropContent` was never exposed as 
option but always set to true!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to