rombert commented on pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/4#issuecomment-818624332


   Hi @valtsu3000 and thanks for the PR! I see a couple of unrelated changes, 
it would be good to remove them from the PR:
   
   - we don't use GitHub actions so please remove ` .github/workflows/build.yml`
   - the changes to pom.xml are unnecessary since we configure SonarCloud 
differently, please remove them
   - we intentionally catch `Throwable` instead of `Exception` so keep that as 
it is
   - by extracting the `repositoryInit` method you've changed to flow - when 
exceptions are caught the method is no longer stopped early
   
   In the end, I would suggest simply changing the log message, it's the 
simplest and most straightforwad action. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to