stefan-egli commented on a change in pull request #11:
URL: 
https://github.com/apache/sling-org-apache-sling-event/pull/11#discussion_r612396444



##########
File path: pom.xml
##########
@@ -195,17 +195,14 @@
         <dependency>
             <groupId>org.osgi</groupId>
             <artifactId>osgi.core</artifactId>
-            <version>6.0.0</version>
         </dependency>
         <dependency>
             <groupId>org.osgi</groupId>
             <artifactId>osgi.cmpn</artifactId>
-            <version>6.0.0</version>
         </dependency>
         <dependency>
             <groupId>org.osgi</groupId>
             <artifactId>org.osgi.service.event</artifactId>

Review comment:
       ok, test seems to work without this. 
   
   However, I feel like this is going down a rabbit hole, and I'd prefer to 
continue for now and look at this later. 
   
   @kwin, are you -1 on shipping with this included? The parent pom says 
"preferred", so that doesn't sound like a must.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to