[
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10318:
------------------------------------
Description:
There are 4 boolean flags which influence the import behaviour:
# overwrite
# overwriteProperties
# merge
# mergeProperties
The latter two have been added with SLING-8243. Currently the behaviour
differs between JSON and XML Import and also from the Javadoc
the differences between {{overwrite}} and {{merge}} are not really clear
(https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).
For me the flag {{merge}} seems a bit misleading, as the javadoc indicates this
will replace all old content (nodes and properties or only nodes). Usually when
you refer to a merge you also keep some part of the existing content. It seems
that {{merge}} should rather be named something like {{replace}}. WDYT?
was:
There are 4 boolean flags which influence the import behaviour:
# overwrite
# overwriteProperties
# merge
# mergeProperties
The latter two have been added with SLING-8243. Currently the behaviour
differs between JSON and XML Import and also from the Javadoc at the
differences between {{overwrite}} and {{merge}} is not really clear
(https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).
For me the flag {{merge}} seems a bit misleading, as the javadoc indicates this
will replace all old content (nodes and properties or only nodes). Usually when
you refer to a merge you also keep some part of the existing content. It seems
that {{merge}} should rather be named something like {{replace}}. WDYT?
> Content Loader - Fix merge and overwrite options
> ------------------------------------------------
>
> Key: SLING-10318
> URL: https://issues.apache.org/jira/browse/SLING-10318
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR ContentLoader 2.4.0
> Reporter: Konrad Windszus
> Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> There are 4 boolean flags which influence the import behaviour:
> # overwrite
> # overwriteProperties
> # merge
> # mergeProperties
> The latter two have been added with SLING-8243. Currently the behaviour
> differs between JSON and XML Import and also from the Javadoc
> the differences between {{overwrite}} and {{merge}} are not really clear
> (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).
> For me the flag {{merge}} seems a bit misleading, as the javadoc indicates
> this will replace all old content (nodes and properties or only nodes).
> Usually when you refer to a merge you also keep some part of the existing
> content. It seems that {{merge}} should rather be named something like
> {{replace}}. WDYT?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
