karlpauls commented on a change in pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615709459
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
##########
@@ -133,6 +135,9 @@
@Option(names = { "-u", "--unreferenced-artifacts-output-directory" },
description = "The output directory where unreferenced artifacts will be
deployed.", required = false)
private File unreferencedArtifactsOutputDirectory;
+ @Option(names = { "-c", "--cndUri" }, description = "A URI returning a CND
file. Used for resolving namespace prefixes in Sling-Initial-Content in
addition to the namespaces given in the bundle headers", required = false)
+ private List<URI> cndUris = new ArrayList<>();
Review comment:
I was hoping you could do something similar like we did for the service
users - i.e., parse the repoinit and use the information from it. An example
would be here:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/5be6cf3b0ce39372598343f015c9276cdb220909/src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java#L185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
