[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on a change in pull request #2: SLING-10204 : less noisy logging on unregistration

[GitBox]

stefan-egli commented on a change in pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/2#discussion_r616558352



##########
File path: src/main/java/org/apache/sling/discovery/oak/OakDiscoveryService.java
##########
@@ -390,7 +390,16 @@ protected void bindPropertyProvider(final PropertyProvider 
propertyProvider,
                 propertyProvider);
 
         synchronized (lock) {
-            this.bindPropertyProviderInteral(propertyProvider, props);
+            try {
+                this.bindPropertyProviderInteral(propertyProvider, props);
+            } catch (RuntimeException re) {
+                // SLING-10204 : catch and instead log less noisy as this can 
legitimately happen
+                if (logger.isDebugEnabled()) {

Review comment:
       Thanks! I've now simplified as you suggested, indeed clearer and easier 
to read




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org