kwin commented on a change in pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#discussion_r616814155
##########
File path: src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java
##########
@@ -203,6 +204,14 @@ public static void setPrincipalAcl(Session session, String
principalName, Collec
}
final PrincipalAccessControlList acl =
getPrincipalAccessControlList(acMgr, principal);
+ if (acl == null) {
Review comment:
`getPrincipalAccessControlList` is a private method and only called from
here, therefore leaving the exception handling here seems fine. Also I wouldn't
do more changes in this context, this was primarily to revert SLING-9449 so the
null check has always been here!
I will add a javadoc to that method then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
