[ 
https://issues.apache.org/jira/browse/SLING-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326112#comment-17326112
 ] 

Mohit Arora commented on SLING-10178:
-------------------------------------

[~marett], [~cschneider] can you please review this JIRA and provide your 
inputs?

> Queueitem should be moved to error queue if the distribution package does not 
> exist anymore
> -------------------------------------------------------------------------------------------
>
>                 Key: SLING-10178
>                 URL: https://issues.apache.org/jira/browse/SLING-10178
>             Project: Sling
>          Issue Type: Bug
>          Components: Content Distribution
>    Affects Versions: Content Distribution Core 0.4.2
>            Reporter: Mohit Arora
>            Priority: Major
>
> There can be a case when the distribution package has been processed but the 
> queueitem has not been removed properly and is being re-processed. In such a 
> case (when the associated distribution package is null), [the queue item is 
> simply 
> removed|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L159-L162].
>  Thus, the user does not have the ability to check what happened. If a 
> queueitem was sent to processing without the corresponding distribution 
> package, then something must have errored, either the package was distributed 
> successfully but the queueitem was not [removed successfully by the 
> QueueProcessor|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/simple/SimpleDistributionQueueProcessor.java#L55]
>  or some other code bug. In such a case we can consider moving the queueitem 
> to error queue instead of just removing it with an error log.
> cc - [~ashishc]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to