anchela commented on a change in pull request #58:
URL: https://github.com/apache/sling-site/pull/58#discussion_r617402384



##########
File path: 
src/main/jbake/content/documentation/the-sling-engine/service-authentication.md
##########
@@ -100,15 +100,23 @@ described above consists of three parts:
 The first part is a new OSGi Service `ServiceUserMapper`. The
 `ServiceUserMapper` service allows for mapping *Service IDs* comprised of
 the *Service Names* defined by the providing bundles and optional *Subservice 
Name*
-to ResourceResolver and/or JCR Repository user IDs or principals 
([SLING-6939](https://issues.apache.org/jira/browse/SLING-6963)). This mapping 
is configurable
+to ResourceResolver and/or JCR Repository principal names 
([SLING-6939](https://issues.apache.org/jira/browse/SLING-6963)) or 
+user IDs ([SLING-6939](https://issues.apache.org/jira/browse/SLING-6963)). 
This mapping is configurable
 such that system administrators are in full control of assigning users to 
services.
 
 The `ServiceUserMapper` defines the following API:
 
     #!java
+    Iterable<String> getServicePrincipalNames(Bundle bundle, String 
subServiceName);
+     
+The alternative API (getting service user ID as shown below) has been 
deprecated for security reasons and will be removed
+in future releases. See 
[SLING-6939](https://issues.apache.org/jira/browse/SLING-6963) for details.

Review comment:
       oh.... thanks for spotting... that's obviously an oversight. the 
deprecation is covered with SLING-10321. i will fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to