kwin commented on a change in pull request #84:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/84#discussion_r635884408
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageUtils.java
##########
@@ -90,6 +90,7 @@ private VaultPackageUtils() {
public static void setDependencies(@Nullable Set<Dependency> dependencies,
@NotNull Properties properties) {
Review comment:
maybe we should cleanup property `dependencies-locations` as well. In
addition the Manifest may contain dependency information as well
(https://jackrabbit.apache.org/filevault/properties.html#Manifest_File),
although this is not evaluated AFAIK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
