cziegeler commented on a change in pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646426608
########## File path: src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java ########## @@ -43,8 +44,20 @@ /** * Shutdown the provider. + * @deprecated Use {@link #close()} instead. */ - void shutdown(); + @Deprecated + default void shutdown() { + Review comment: No, AM implements close without throwing an exception, see https://github.com/apache/sling-org-apache-sling-feature/blob/master/src/main/java/org/apache/sling/feature/io/artifacts/ArtifactManager.java#L126 AM also implements AutoCloseable - so AM can already be used in a try-with-resources block. Nothing needs to change there, and we can apply the same pattern to the ArtifactProvider - let it implement AutoCloseable with a default method close() not throwing an exception and calling shutdown -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org