joerghoh commented on a change in pull request #18:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/18#discussion_r646661450
##########
File path:
src/main/java/org/apache/sling/jcr/repoinit/impl/RepositoryInitializerFactory.java
##########
@@ -122,14 +131,47 @@ public void processRepository(final SlingRepository repo)
throws Exception {
continue;
}
final List<Operation> ops = parser.parse(new
StringReader(script));
- log.info("Executing {} repoinit operations",
ops.size());
- processor.apply(s, ops);
- s.save();
+ String msg = String.format("Executing %s repoinit
operations", ops.size());
+ log.info(msg);
+ applyOperations(s,ops,msg);
}
}
} finally {
s.logout();
}
}
}
+
+
+ /**
+ * Apply the operations within a session, support retries
+ * @param session the JCR session to use
+ * @param ops the list of operations
+ * @param logMessage the messages to print when retry
+ * @throws Exception if the application fails despite the retry
+ */
+ private void applyOperations(Session session, List<Operation> ops, String
logMessage) throws Exception {
+
+ RetryableOperation retry = new
RetryableOperation.Builder().withBackoffBase(1000).withMaxRetries(3).build();
+ boolean successful = retry.apply(() -> {
+ try {
+ processor.apply(session, ops);
+ session.save();
+ return true;
+ } catch (RepositoryException e) {
+ log.error("(temporarily) failed to apply repoinit
operations",e);
Review comment:
Yes, that is possible, but I don't think it makes sense to suppress it,
because we are never sure that it will always the same reason and the same
exception. It's completely ok if the different RepositoryExceptions are thrown.
Anyway, I don't expect this situation to happen that often, as we have seen
it only in rare circumstances. So that's for me an acceptable logging overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
