[ https://issues.apache.org/jira/browse/SLING-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359203#comment-17359203 ]
Dominik Süß commented on SLING-10469: ------------------------------------- [~kwin] - that is a bit more tricky (unless we just duplicate the logic. The point fix makes sure the corresponding substructures are detected by the very same Handler and then simply ignores those structures. Therefore for an even more generic refactoring I suggest to create another one. In the end this is an edge case when somebody produces the package from an existing repository - which I so far only observed a few times when someone extracts the configs - but you are right, people "may" break bundle entries the same way. > Breaking leftover dir folders for configs in generated packages > --------------------------------------------------------------- > > Key: SLING-10469 > URL: https://issues.apache.org/jira/browse/SLING-10469 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter > Affects Versions: Content-Package to Feature Model Converter 1.1.4 > Reporter: Dominik Süß > Priority: Major > > In case a configuration package is generated from an existing repository due > to the serialization logic for each nt:file representing a configuration > there is also a .dir folder (with an embedded .content.xml declaring nodetype > etc.) as a sibling. > The configuration handlers only handle the binaries but don't recognize the > sibling structures which will make them remain in the package and therefore > render the packages invalid as the binary belonging to the nt:file is being > stripped out. > To prevent this (rare but existing) edge case the Configuration handler > should also detect the dir folder and drop it from assembly in the target > package as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)