bdelacretaz commented on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/18#issuecomment-857487885


   >  Moving the retries into these specific operations doesn't make much sense 
to me, as it would duplicate a lot of code with no benefit.
   
   It is probably possible to design the code so that the various Operations 
can indicate if they need to be retried or not.
   
   But as you say, the retrying implementation will do nothing in the vast 
majority of cases, and only slow down the actual failing cases. As repoinit is 
generally meant to be executed at startup only that's not really a problem.
   
   I'll comment on the general discussions about retries at SLING-10418 as 
that's where the discussion started. I'm basically ok with adding the retry 
mechanism to everything as you suggested. Especially as you're only retrying on 
`InvalidItemStateException` now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to