[
https://issues.apache.org/jira/browse/SLING-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364193#comment-17364193
]
Konrad Windszus edited comment on SLING-10496 at 6/16/21, 10:29 AM:
--------------------------------------------------------------------
There are two potential solutions coming to my mind:
# Instead of activating a dedicated profile id just set a Maven property with
name "ci". That could be evaluated for implicit profile activation on modules
which need that.
# Leave the explicit profile activation but include an empty profile with that
name in the parent pom.xml
I have a slight tendency towards 1 although that would potentially be
non-backwards compatible. But AFAIK the only module leveraging the profile "CI"
is Sling Starter
(https://github.com/apache/sling-org-apache-sling-starter/commit/d9861d13179709b21946092eea4f802532dec176#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R233)
which can be easily converted to activation via property.
Any opinions?
was (Author: kwin):
There are two potential solutions coming to my mind:
# Instead of activating a dedicated profile id just set a Maven property with
name "CI". That could be evaluated for implicit profile activation on modules
which need that.
# Leave the explicit profile activation but include an empty profile with that
name in the parent pom.xml
I have a slight tendency towards 1 although that would potentially be
non-backwards compatible. But AFAIK the only module leveraging the profile "CI"
is Sling Starter
(https://github.com/apache/sling-org-apache-sling-starter/commit/d9861d13179709b21946092eea4f802532dec176#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R233)
which can be easily converted to activation via property.
Any opinions?
> Prevent warning about non-existing profile "ci"
> -----------------------------------------------
>
> Key: SLING-10496
> URL: https://issues.apache.org/jira/browse/SLING-10496
> Project: Sling
> Issue Type: Improvement
> Components: General
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: Parent 44
>
>
> Most builds with Jenkins emit the following warning
> {code}
> [WARNING] The requested profile "ci" could not be activated because it does
> not exist.
> {code}
> This is especially important for the Maven 4
> (https://issues.apache.org/jira/browse/MNG-7051) as that will break by
> default if the profile is not found.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
