[ 
https://issues.apache.org/jira/browse/SLING-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368982#comment-17368982
 ] 

Konrad Windszus edited comment on SLING-10538 at 6/24/21, 5:22 PM:
-------------------------------------------------------------------

This is IMHO a backwards incompatible change in case the property 
{{sling.installer.config.mergeSchemes}} is set. Without this feature properties 
which are not mentioned would get default value, but with it it will use values 
from configurations with lower priorities. Wouldn't it make more sense for 
configurations to explicitly opt-in to the new merge behaviour. We could e.g. 
establish an artificial property like {{:mergeMode=true}} which would only be 
evaluated by the OSGi installer and not passed to the configuration admin. That 
way you can determine for each configuration resource individually which merge 
mode you want.


was (Author: kwin):
This is IMHO a backwards incompatible change in case the property 
{{sling.installer.config.mergeSchemes}} is set. Without this feature unset 
properties would use defaults, but with it it will use values from 
configurations with lower priorities. Wouldn't it make more sense for 
configurations to explicitly opt-in to the new merge behaviour. We could e.g. 
establish an artificial property like {{:mergeMode=true}} which would only be 
evaluated by the OSGi installer and not passed to the configuration admin. That 
way you can determine for each configuration resource individually which merge 
mode you want.

> Support merging of configurations
> ---------------------------------
>
>                 Key: SLING-10538
>                 URL: https://issues.apache.org/jira/browse/SLING-10538
>             Project: Sling
>          Issue Type: Improvement
>          Components: Installer
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: Installer Core 3.11.6, Installer Configuration Factory 
> 1.3.6
>
>
> Today, the installer support for configurations applies a configuration as a 
> unit. While this is useful for many use cases, there are use cases where for 
> example an application provides an ootb OSGi configuration and the 
> customization of that configuration should only contain the changed 
> properties but not repeat all properties from the application.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to