mohiaror commented on a change in pull request #55:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/55#discussion_r708009566
##########
File path:
src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java
##########
@@ -92,7 +92,7 @@ public boolean process(@NotNull String queueName, @NotNull
DistributionQueueEntr
final long endTime = System.currentTimeMillis();
- distributionLog.debug("[{}] ITEM-PROCESSED item={}, status={},
processingTime={}ms", queueName, queueItem, success, endTime - startTime);
+ distributionLog.info("[{}] ITEM-PROCESSED item={}, status={},
processingTime={}ms", queueName, queueItem, success, endTime - startTime);
Review comment:
@cschneider thanks for the review. My motivation behind the change was
to also log the queueItemID in case of successful processing of item. The item
ID is currently only logged at debug level or at error/warn level in case of an
exception. I have updated the existing log info for successful distribution of
item and added the queue item ID to it -
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/55/commits/33b54a5a56381fd7a3c60db46d6001cbf5426780
Would this be an acceptable change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
