[GitHub] [sling-org-apache-sling-commons-log] rombert edited a comment on pull request #8: SLING-9528 - Update commons log to parent pom 39 or newer

[GitBox]

rombert edited a comment on pull request #8:
URL: 
https://github.com/apache/sling-org-apache-sling-commons-log/pull/8#issuecomment-940112272


   @kwin @karlpauls  - the build now fails because of baselining issues in the 
Logback packages, e.g.
   
   ```
   [ERROR] Baseline mismatch for package ch.qos.logback.classic.encoder, MAJOR 
change. Current is 1.2.6, repo is 1.2.3, suggest 2.0.0 or -
   MAJOR                PACKAGE    ch.qos.logback.classic.encoder
     MAJOR              CLASS      
ch.qos.logback.classic.encoder.PatternLayoutEncoder
       REMOVED          METHOD     setParent(ch.qos.logback.core.Appender)
         REMOVED        RETURN     void
       ADDED            METHOD     
setParent(ch.qos.logback.core.spi.ContextAware)
         ADDED          RETURN     void
     REMOVED            VERSION    1.2.3
     ADDED              VERSION    1.2.6
   ```
   
   I think that we should ignore basellning here and keep the logback exports 
at the logback bundle version as a compromise, otherwise things can become 
quite confusing. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org