cziegeler commented on a change in pull request #53:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#discussion_r762535763
##########
File path:
src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverFactoryActivator.java
##########
@@ -113,6 +114,9 @@
@Reference
ResourceAccessSecurityTracker resourceAccessSecurityTracker;
+
+ @Reference(cardinality = ReferenceCardinality.OPTIONAL, policyOption =
ReferencePolicyOption.GREEDY)
+ private ResourceResolverMetrics metrics;
Review comment:
This reference should also be dynamic, this allows that the field is
updated when the service appears/disappears instead of restarting the
component. The field should be volatile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
