[ https://issues.apache.org/jira/browse/SLING-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455886#comment-17455886 ]
Konrad Windszus edited comment on SLING-10983 at 12/8/21, 5:31 PM: ------------------------------------------------------------------- As removing ACLs cannot easily be prevented (would require some Jackrabbit API) without reworking the overwrite semantics of folder nodes in a more complex way (i.e. keep the existing node, but adjust its primary and mixin types and remove all other (non-protected) properties) I think we have the following options: # keep current behaviour or # bail out in case overwrite:=true is used without the path directive or with path "/" and throw an according exception I would be in favour of option 2 actually, because in all cases I have seen this was not done deliberately but by mistake and it often goes unnoticed. In any case the documentation at https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html# needs to be clarified that * overwrite never starts at root, but always at the path below * overwrite might also remove existing permissions bound to the node was (Author: kwin): As removing ACLs cannot easily be prevented (would require some Jackrabbit API) without reworking the overwrite semantics of folder nodes in a more complex way (i.e. keep the existing node, but adjust its primary and mixin types and remove all other (non-protected) properties) I think we have the following options: # keep current behaviour or # bail out in case overwrite:=true is used without the path directive I would be in favour of option 2 actually, because in all cases I have seen this was not done deliberately but by mistake and it often goes unnoticed. In any case the documentation at https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html# needs to be clarified that * overwrite never starts at root, but always at the path below * overwrite might also remove existing permissions bound to the node > Sling-Initial-Content removes ACLs when using overwrite:=true without path > -------------------------------------------------------------------------- > > Key: SLING-10983 > URL: https://issues.apache.org/jira/browse/SLING-10983 > Project: Sling > Issue Type: Bug > Affects Versions: JCR ContentLoader 2.4.2 > Reporter: Konrad Windszus > Assignee: Konrad Windszus > Priority: Major > > In the context of > https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1 > it turned out that if you use a Sling-Initial-Content header without an > explicit {{path}} directive it will remove ACLs on nodes below the root node > (if it is a parent node of the node to be updated by Sling-Initial-Content). -- This message was sent by Atlassian Jira (v8.20.1#820001)