joerghoh commented on a change in pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-metrics/pull/1#discussion_r781046091
##########
File path: src/main/java/org/apache/sling/commons/metrics/Gauge.java
##########
@@ -34,14 +43,12 @@
* };
* </code></pre>
*
- * <p> A Gauge instance should be registered with OSGi ServiceRegistry with
{@code Gauge#NAME} set
- * to Gauge name. Then the Gauge instance would be registered with
MetricService via whiteboard
- * pattern
+
*
* @param <T> the type of the metric's value
*/
@ConsumerType
-public interface Gauge<T> {
+public interface Gauge<T> extends Metric {
Review comment:
ok, I understand.
Extending the ```Metric``` interface is also not really necessary from an
API point of view, it is only needed at the implementation level. I will change
the implementation so the existing Gauge interface (as a ConsumerType) will
stay as it currently is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
