dulvac commented on a change in pull request #28:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/28#discussion_r801860444



##########
File path: 
src/test/java/org/apache/sling/testing/AbstractSlingClientGetUrlTest.java
##########
@@ -130,7 +130,7 @@ public void testGetUrlWithParam() throws ClientException {
         SlingClient c = new SlingClient(URI.create(serverUrl), "USER", "PWD");
         assertEquals("", URI.create(expectedUrl), c.getUrl(inputPath));
         assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, null));
-        assertEquals(URI.create(expectedUrl + "?"), c.getUrl(inputPath, new 
ArrayList<NameValuePair>()));
+        assertEquals(URI.create(expectedUrl), c.getUrl(inputPath, new 
ArrayList<NameValuePair>()));

Review comment:
       This actually seems to be the correct behaviour, now




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to