Buuhuu commented on pull request #61: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/61#issuecomment-1036353203
The `null` was just returned all the way to the caller causing [the following test](https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/test/java/org/apache/sling/resourceresolver/impl/MockedResourceResolverImplTest.java#L555-L557) to fail ``` testMapping() { ... path = resourceResolver.map("/content.html"); Assert.assertEquals("/content.html", path); ... } MockedResourceResolverImplTest.testMapping:574 expected:</content.html> but was:<null> ``` Looks like a regression to me that was hidden by the fact that `testMapping()` did not test with the `MapEntries` initialised. But I cannot reason about the behaviour being tested here. Anyway, as all the tests pass now this change should be good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
