stefanseifert commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1039240515
yes - but this is a rather bigger step, we do not have a good example for this (already discussed this ab bit with @kwin in the past - it will by a bit fiddly to get this all running). ideally, the ITs should also be moved to the main module (caconfig-impl) to be executed together with the actual code. but this is a bigger project to get it all together smoothly. the same pattern is currently used for the sling models integration tests, and there it's even more important as most of the models code is not covered by unit tests but only by integration tests. also i always prefer running the ITs against a bit older version of sling to make sure it is somewhat backward compatible (e.g. comparable to AEM 6.5) so, it might be easier to bet the few missing deps here first to be able to validate https://github.com/apache/sling-org-apache-sling-caconfig-impl/tree/improvement/SLING-11114-use-LazySupplier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
