[ https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506438#comment-17506438 ]
Eric Norman edited comment on SLING-11158 at 3/14/22, 6:39 PM: --------------------------------------------------------------- [~rombert] Thanks for the review. I've made some changes that I think address your concerns. I also would like to hear any other opinions about if this is the best path. I see that the [readme|https://github.com/apache/sling-org-apache-sling-feature-launcher] is still describing the old single jar technique, so that may need some updates too based on what is decided here. was (Author: enorman): [~rombert] Thanks for the review. I've made some changes that I think address your concerns. I am would like to hear any other opinions about if this is the best path. I see that the [readme|https://github.com/apache/sling-org-apache-sling-feature-launcher] is still describing the old single jar technique, so that may need some updates too based on what is decided here. > The starter's "Start Sling" instructions don't work with feature launcher > v1.1.28 or later > ------------------------------------------------------------------------------------------ > > Key: SLING-11158 > URL: https://issues.apache.org/jira/browse/SLING-11158 > Project: Sling > Issue Type: Bug > Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher > 1.2.0 > Reporter: Eric Norman > Priority: Major > Fix For: Feature Launcher Maven Plugin 0.1.4, Starter 13 > > Time Spent: 50m > Remaining Estimate: 0h > > After the SLING-10956 changes, launching the Starter with the README provided > instructions while using the v1.1.28 or later feature launcher does not work > anymore. > For example, > {noformat} > $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f > target/slingfeature-tmp/feature-oak_tar.json > Error: Unable to initialize main class > org.apache.sling.feature.launcher.impl.Main > Caused by: java.lang.NoClassDefFoundError: > org/apache/commons/cli/ParseException{noformat} > > Also, the start goal of the feature-launcher-maven-plugin fails with the same > exception when paired with a featureLauncherVersion of 1.1.28 or later. > -- This message was sent by Atlassian Jira (v8.20.1#820001)