[GitHub] [sling-org-apache-sling-commons-cache-impl] rombert commented on a change in pull request #1: Fix build issues and update to sling 47

[GitBox]

rombert commented on a change in pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-commons-cache-impl/pull/1#discussion_r839365463



##########
File path: README.md
##########
@@ -1,8 +1,8 @@
 [![Apache 
Sling](https://sling.apache.org/res/logos/sling.png)](https://sling.apache.org)
 
- [![Build 
Status](https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-commons-cache-impl/job/master/badge/icon)](https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-commons-cache-impl/job/master/) [![Coverage](https://sonarcloud.io/api/project_badges/measure?project=apache_sling-org-apache-sling-commons-cache-impl&metric=coverage)](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-cache-impl) [![Sonarcloud
 
Status](https://sonarcloud.io/api/project_badges/measure?project=apache_sling-org-apache-sling-commons-cache-impl&metric=alert_status)](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-cache-impl) [![Contrib](https://sling.apache.org/badges/status-contrib.svg)](https://github.com/apache/sling-aggregator/blob/master/docs/status/contrib.md)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
+ [![Build 
Status](https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-commons-cache-impl/job/master/badge/icon)](https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-commons-cache-impl/job/master/) [![Test
 
Status](https://img.shields.io/jenkins/tests.svg?jobUrl=https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-commons-cache-impl/job/master/)](https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-commons-cache-impl/job/master/test/?width=800&height=600) [![Coverage](https://sonarcloud.io/api/project_badges/measure?project=apache_sling-org-apache-sling-commons-cache-impl&metric=coverage)](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-commons-cache-impl) [![Sonarcloud
 
Status](https://sonarcloud.io/api/project_badges/measure?project=apache_sling-org-apache-sling-commons-cache-impl&metric=alert_status)](https://sonarcloud.io/dashboard?id=apache_sling-o
 
rg-apache-sling-commons-cache-impl) [![JavaDoc](https://www.javadoc.io/badge/org.apache.sling/org.apache.sling.api.svg)](https://www.javadoc.io/doc/org.apache.sling/org.apache.sling.api) [![Maven
 
Central](https://maven-badges.herokuapp.com/maven-central/org.apache.sling/org.apache.sling.api/badge.svg)](https://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.sling%22%20a%3A%22org.apache.sling.api%22)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 
-# Apache Sling Cache API Implementation support library
+# Apache Sling Cache API Implementation library

Review comment:
       Not sure this is needed.

##########
File path: pom.xml
##########
@@ -22,26 +22,31 @@
     <modelVersion>4.0.0</modelVersion>
     <parent>
         <groupId>org.apache.sling</groupId>
-        <artifactId>sling</artifactId>
-        <version>16</version>
-        <relativePath/>
+        <artifactId>sling-bundle-parent</artifactId>
+        <version>47</version>
+        <relativePath />
     </parent>
 
     <artifactId>org.apache.sling.commons.cache.impl</artifactId>
     <version>0.1-SNAPSHOT</version>
-    <packaging>jar</packaging>
 
     <name>Apache Sling Cache API Implementation support library</name>
     <description>
         This bundle provides an implementation support for Cache 
implementations. It is a utility jar that should be embedded.
     </description>
 
+    <properties>
+        <sling.java.version>8</sling.java.version>
+        <project.build.outputTimestamp>1</project.build.outputTimestamp>
+        <bnd.baseline.skip>true</bnd.baseline.skip>

Review comment:
       This should not be needed.

##########
File path: pom.xml
##########
@@ -22,26 +22,31 @@
     <modelVersion>4.0.0</modelVersion>
     <parent>
         <groupId>org.apache.sling</groupId>
-        <artifactId>sling</artifactId>
-        <version>16</version>
-        <relativePath/>
+        <artifactId>sling-bundle-parent</artifactId>

Review comment:
       This is not an OSGi bundle, so please use org.apache.sling:sling:47 
instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org