[ 
https://issues.apache.org/jira/browse/SLING-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052439#comment-13052439
 ] 

Bertrand Delacretaz edited comment on SLING-1476 at 6/21/11 9:20 AM:
---------------------------------------------------------------------

I had a quick look and IMO the MBeanAdminImpl.registerMBean method needs 
synchronization around ManagementFactory.getPlatformMBeanServer()

Also, I think the bundle that supplies the MBeanAdmin service should not 
contain a Filter, which will "pollute" the filter chain. 

It's good to have an example MBean in the bundle (for integration testing for 
example), but I'd make that return something simpler like 
System.currentTimeMillis() for example, or the number of registered MBeans.

(and thanks Joerg for your contribution, of course ;-)

      was (Author: bdelacretaz):
    I had a quick look and IMO the MBeanAdminImpl.registerMBean method needs 
synchronization around ManagementFactory.getPlatformMBeanServer()

Also, I think the bundle that supplies the MBeanAdmin service should not 
contain a Filter, which will "pollute" the filter chain. 

It's good to have an example MBean in the bundle (for integration testing for 
example), but I'd make that return something simpler like 
System.currentTimeMillis() for example, or the number of registered MBeans.
  
> provide number of processed requests
> ------------------------------------
>
>                 Key: SLING-1476
>                 URL: https://issues.apache.org/jira/browse/SLING-1476
>             Project: Sling
>          Issue Type: New Feature
>          Components: Engine
>    Affects Versions: Engine 2.0.6
>            Reporter: Jörg Hoh
>            Priority: Minor
>         Attachments: org.apache.sling.jmx.zip
>
>
> For status monitoring it would be useful to have the number of total 
> processed requests since restart of the JVM. Is it possible to have a 
> "statistics" component which could provide such numbers?
> (The "manual" way to do it would be writing a very simple RequestFilter which 
> just increments a counter and expose this object as OSGI component.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to