[ 
https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557124#comment-17557124
 ] 

Oliver Lietz commented on SLING-11398:
--------------------------------------

{quote}What is unclear about the comments in that test class?  It states in two 
places that it is for a fragment.  Once at the top of the class and again right 
above where the groovy-jsr223 is added to the configuration.  People shouldn't 
be looking here for an explanation of the differences between groovy 
versions.{quote}
People tend to update versions without understanding the impact. Therefore I 
prefer to have an extended comment:
{{// factory is defined in this fragment artifact – other versions of this 
bundle (e.g. 3.0.1) were released as regular bundle, not as fragment}}

> handle serviceloader ScriptEngineFactory defined in a fragment bundle
> ---------------------------------------------------------------------
>
>                 Key: SLING-11398
>                 URL: https://issues.apache.org/jira/browse/SLING-11398
>             Project: Sling
>          Issue Type: Bug
>            Reporter: Eric Norman
>            Assignee: Eric Norman
>            Priority: Major
>             Fix For: Scripting Core 2.4.10
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Handle loading of ScriptEngineFactory service loader 
> (/META-INF/services/javax.script.ScriptEngineFactory) files that exist in a 
> fragment.
> For example, consider the groovy ScriptEngine included in the starter that 
> has these:
>     Host Bundle - org.codehaus.groovy:groovy:3.0.9
>     Fragment - org.codehaus.groovy:groovy-jsr223:3.0.9
>  
> Expected:
> The groovy ScriptEngineFactory declared in the groovy-jsr223 fragment should 
> be discovered and made available.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to