[
https://issues.apache.org/jira/browse/SLING-11408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575201#comment-17575201
]
Konrad Windszus edited comment on SLING-11408 at 8/4/22 10:39 AM:
------------------------------------------------------------------
I cannot reproduce. When building the current master branch
(https://github.com/apache/sling-org-apache-sling-feature-launcher/commit/072fe2ae0fa1ae0a931c546aa25ec60a4fc75194)
I get the following contents for {{target/appassembler}}
{code}
├── bin
│ ├── launcher
│ └── launcher.bat
└── lib
├── commons-cli-1.4.jar
├── commons-lang3-3.12.0.jar
├── commons-text-1.9.jar
├── org.apache.felix.cm.json-1.0.6.jar
├── org.apache.sling.commons.johnzon-1.2.14.jar
├── org.apache.sling.feature-1.2.30.jar
├── org.apache.sling.feature.launcher-1.2.1-SNAPSHOT.jar
├── org.osgi.service.configurator-1.0.0.jar
├── org.osgi.util.converter-1.0.9.jar
├── org.osgi.util.function-1.0.0.jar
├── osgi.core-8.0.0.jar
└── slf4j-api-1.7.25.jar
{code}
with
{code}
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /opt/homebrew/Cellar/maven/3.8.6/libexec
Java version: 11.0.16, vendor: Eclipse Adoptium, runtime:
/Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
Default locale: en_DE, platform encoding: UTF-8
OS name: "mac os x", version: "12.5", arch: "aarch64", family: "mac"
{code}
was (Author: kwin):
I cannot reproduce. When building the current master branch
(https://github.com/apache/sling-org-apache-sling-feature-launcher/commit/072fe2ae0fa1ae0a931c546aa25ec60a4fc75194)
I get the following contents for {{target/appassembler}}
{code}
├── bin
│ ├── launcher
│ └── launcher.bat
└── lib
├── commons-cli-1.4.jar
├── commons-lang3-3.12.0.jar
├── commons-text-1.9.jar
├── org.apache.felix.cm.json-1.0.6.jar
├── org.apache.sling.commons.johnzon-1.2.14.jar
├── org.apache.sling.feature-1.2.30.jar
├── org.apache.sling.feature.launcher-1.2.1-SNAPSHOT.jar
├── org.osgi.service.configurator-1.0.0.jar
├── org.osgi.util.converter-1.0.9.jar
├── org.osgi.util.function-1.0.0.jar
├── osgi.core-8.0.0.jar
└── slf4j-api-1.7.25.jar
{code}
with
{code}
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /opt/homebrew/Cellar/maven/3.8.6/libexec
Java version: 11.0.16, vendor: Eclipse Adoptium, runtime:
/Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home
Default locale: en_DE, platform encoding: UTF-8
OS name: "mac os x", version: "12.5", arch: "aarch64", family: "mac"
{code}
> Make sure that feature launcher contains only necessary runtime dependencies
> ----------------------------------------------------------------------------
>
> Key: SLING-11408
> URL: https://issues.apache.org/jira/browse/SLING-11408
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Affects Versions: Feature Model Launcher 1.2.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: Feature Model Launcher 1.2.2
>
>
> Feature Launcher uses {{appassembler-maven-plugin}} for packaging all runtime
> dependencies into the classpath. As a lot of required dependencies have scope
> "provided" (due to primary usage within OSGi) it is hard to come up with a
> correct runtime classpath. The enforcer rule from SLING-11369 should be
> leveraged to automatically enforce a complete runtime classpath.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
