Hi Konrad, No concerns - feel free to merge https://github.com/apache/sling-site/pull/96 <https://github.com/apache/sling-site/pull/96>.
Thanks, Radu > On 11 Aug 2022, at 16:36, Konrad Windszus <k...@apache.org> wrote: > > I also ran into that issue recently and I still think that the site goal is > enough (no need for stage, > https://maven.apache.org/plugins/maven-site-plugin/stage-mojo.html). > > Every URL we would put into the distributionManagement site URL of the parent > would just be a guess and could be wrong. > > Any concerns before removing the "site:stage" goal from step 2 in > https://sling.apache.org/documentation/development/release-management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable? > > Thanks, > Konrad > > On 2021/09/21 18:12:27 Radu Cotescu wrote: >> Hi Konrad, >> >>> On 21 Sep 2021, at 19:35, Konrad Windszus <konra...@gmx.de> wrote: >>> >>> Hi Radu, >>> I never use the site goals "deploy" or "stage" for Sling modules. Instead >>> of the former we have a rather manual process outlined in >>> https://sling.apache.org/documentation/development/release-management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable. >>> The latter is only useful to test links between module sites in a multi >>> module build. I don't think we have that use case in Sling. >>> >>> The distributionManagement url I removed from parent was invalid and IMHO >>> never used. >> >> Yes, I don’t dispute that. >> >>> Any reason why a simple "mvn clean site" does not suffice to test the Maven >>> site? >>> >> >> That should work. The only question is why did we recommend to copy the >> staged version to the folder where we publish the documentation for the >> Maven plugins. In my case the site and staging folders have the exact same >> content. If that’s always the case, then we should update our release >> management docs. >> >> Thanks, >> Radu >> >>
