[ 
https://issues.apache.org/jira/browse/SLING-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062784#comment-13062784
 ] 

Antonio Sanso commented on SLING-2094:
--------------------------------------

Thanks a lot for the revision Carsten.

>I tend to see this as an error handler for this jsp and would resume with 
>rendering.
I got a second though on it and  I do agree with you. Btw it is enough to 
remove this

//need to rethrow the exception (that won't be catched anywhere)
//in order to do not render the other components
throw sje;

in order to resume the rendering.

>The basic difference is that the error page information is transported inside 
>the SlingPageException instead of adding it as a request attribute. 

About this the reason why I have used the request attribute is because the 
exception handling inside the JspServletWrapper doesn't behave as "expected" 
and the doesn't respect the assumption that the SlinPageException is the last 
exception to be handled. So  SlingPageException is not propagated up to the top 
of the jsp engine. At least this is what happened to my when I have applied the 
revision patch (the intengration test didn't pass anymore as well) . WDYT?

> Adding support to call a sling resource for JSP page exception handler  <%@ 
> page errorPage ... %>
> -------------------------------------------------------------------------------------------------
>
>                 Key: SLING-2094
>                 URL: https://issues.apache.org/jira/browse/SLING-2094
>             Project: Sling
>          Issue Type: New Feature
>          Components: Scripting
>            Reporter: Antonio Sanso
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: Scripting JSP 2.0.18
>
>         Attachments: SLING-2094-asanso-patch.txt, 
> SLING-2094-asanso2-patch.txt, SLING-2094-asanso3-patch.txt, 
> SLING-2094-asanso4-patch.txt, SLING-2094-integration-tests.patch, 
> scripting.patch
>
>
> At the moment the JSP page exception handler (<%@ page errorPage ... %>) is 
> not supported as the jsp engine can't resolve the path to the jsp if  this is 
> a repository resource.
> See also the user mailing list  [0] for more details
> [0] http://www.mail-archive.com/users@sling.apache.org/msg01369.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to