[
https://issues.apache.org/jira/browse/SLING-11582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605325#comment-17605325
]
Timothee Maret commented on SLING-11582:
----------------------------------------
That works as well.
> VaultDistrubtionPackageBuilderFactory mixed up ordering of attribute
> definition for type
> ----------------------------------------------------------------------------------------
>
> Key: SLING-11582
> URL: https://issues.apache.org/jira/browse/SLING-11582
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
> Affects Versions: Content Distribution Journal Core 0.1.26
> Reporter: Ben Helleman
> Priority: Major
>
> The VaultDistributionPackageBuilderFactory's AttributeDefintion [0] for
> "type" has the label and values swapped.
> The impact is that someone creating an OSGi configuration that uses the value
> of "in memory packages" will not have in memory packages created as the
> "label" is what is used to check if packages should be created in memory [1].
> The OSGi docs for Option [2] identify the label as being a human readable
> string and the value should be the value.
> At the same time fix the typo in the ObjectClassDefintion [3]
>
> [0]
> [https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java#L76-L80]
>
> [1][https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java#L241]
> [2]
> [http://docs.osgi.org/javadoc/r6/cmpn/org/osgi/service/metatype/annotations/Option.html]
>
> [3]
> [https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VaultDistributionPackageBuilderFactory.java#L71]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
