+1, I can't help with releases atm, so either someone else can step in
or I can do it end of week
Regards
Carsten
Am 26.09.2022 um 14:54 schrieb Robert Munteanu:
Should we start votes for the two new bundles so that we have stable
Starter ITs?
On Mon, 2022-09-26 at 09:32 +0200, Carsten Ziegeler wrote:
The failing tests are actually caused by
a) https://issues.apache.org/jira/browse/SLING-11598 - a "bug" in
auth
core which lets the authentication support re-register on
configuration
change. This should not happen. With Engine 2.12.0 it causes the
engine
to restart. In general, this is not a bug as after some time of
reconfiguration, everything is up and stable again. However, this can
be
easily avoided by fixing auth core and is actually a regression of
auth
core introduced a while back due to refactorings.
b) https://issues.apache.org/jira/browse/SLING-11597 - a bug in junit
scriptable which is implementing servlet request/response interfaces
by
hand (which really should be avoided). Sling engine is expecting
servlet
api 3.0 to work, junit scriptable is not implementing it properly. I
added a workaround
With both issues fixed, starter tests run totally fine on my machine
Regards
Carsten
Am 26.09.2022 um 07:35 schrieb Carsten Ziegeler:
With Engine 2.12.0 I get consistently these failing tests:
[ERROR] Failures:
[ERROR]
DavExDisabledAnonAccessTest>DavExIntegrationTest.tearDown:90-
configureServerAfterTest:33->HttpTestBase.assertPostStatus:412
Unable to enable anonymous access expected:<200> but was:<404>
[ERROR]
DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:46-
configureServerBeforeTest:40->HttpTestBase.assertPostStatus:412
Unable to disable anonymous access expected:<200> but was:<404>
[ERROR] RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70
Expected redirect expected:<302> but was:<401>
[ERROR]
PostSendErrorTest.testNotSuccessfulWithHtmlResponseAndSendError:48-
HttpTestBase.getContent:457 Expected status 500 for
http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
expected:<500> but was:<401>
[ERROR]
PostSendErrorTest.testNotSuccessfulWithJsonResponseAndSendError:88-
HttpTestBase.getContent:457 Expected status 500 for
http://localhost:38719/PostSendErrorTest/1664170496409 (content=)
expected:<500> but was:<401>
[ERROR] Errors:
[ERROR] ServerSideScriptsTest.runScripts:235 » JsonGeneration
write(param) is only val...
[INFO]
[ERROR] Tests run: 572, Failures: 5, Errors: 1, Skipped: 1
Regards
Carsten
Am 26.09.2022 um 06:59 schrieb Carsten Ziegeler:
It seems I cannot even run the starter tests with Engine 2.11.0 -
Sling does not start within a minute
Regards
Carsten
Am 26.09.2022 um 06:47 schrieb Carsten Ziegeler:
I did extensive tests with that engine version and didn't run
into
problems. I don't know much about the tests but maybe they make
assumptions which do not hold true anymore.
We need to dig into this and see what is going on
Regards
Carsten
Am 22.09.2022 um 21:34 schrieb Eric Norman:
-1 for me since I could not successfully run the starter
integration
tests
with this version. Were you expecting that changes would be
required in
the tests to compensate for the changes?
I get anywhere from 4 to 100+ various test failures during
each
build of
the latest starter project after switching to v2.12.0 of the
engine.
Regards,
-Eric
--
Carsten Ziegeler
Adobe
cziege...@apache.org
