Kronnox commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-testing-rules/pull/2#issuecomment-1325065432
> I don't have any specific concerns with this solution. I'd just point out that this solution would be only for consumers who are still using junit4. > > For those that have migrated to junit5, a [BeforeEachCallback](https://junit.org/junit5/docs/current/api/org.junit.jupiter.api/org/junit/jupiter/api/extension/BeforeEachCallback.html) extension would be needed instead of this new rule. > > However, making a fork of the sling-org-apache-sling-testing-rules project that is compatible with junit5 is a larger problem and should probably be considered separately. As everything else is still based on junit4 as well I opted for consistency with this PR. So yeah, as you've already mentioned yourself the junit5 migration would be a larger topic on its own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
