kwin commented on code in PR #8:
URL: 
https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/8#discussion_r1104585446


##########
src/main/java/org/apache/sling/resourcemerger/impl/picker/ResourceTypeHierarchyBasedResourcePicker.java:
##########
@@ -99,6 +100,11 @@ public List<Resource> pickResources(ResourceResolver 
resolver, String relativePa
         return resources;
     }
 
+    @Activate
+    protected void activate(final Configuration config) {
+

Review Comment:
   Maybe add a comment why this is necessary, e.g. reference 
https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-ordering.generated.properties
 and state that otherwise the component properties are not populated from the 
ObjectType defaults.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to