kwin commented on code in PR #10: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/10#discussion_r1106962764
########## src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java: ########## @@ -64,7 +67,11 @@ protected void deactivate() { } @Reference(policy = ReferencePolicy.DYNAMIC, cardinality = ReferenceCardinality.MULTIPLE) - public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, Map<String, Object> properties) { + public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, Review Comment: @raducotescu TBH I don't understand this. Why are the defaults not injected in the bind method? The spec says > An event method can take one or more parameters.An event method can take one or more parameters. ... > Map - An unmodifiable Map containing the service properties of the bound service. This Map must additionally implement Comparable with the compareTo method comparing service property maps using the same ordering as ServiceReference.compareTo based upon service ranking and service id. (https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-method.injection) ########## src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java: ########## @@ -64,7 +67,11 @@ protected void deactivate() { } @Reference(policy = ReferencePolicy.DYNAMIC, cardinality = ReferenceCardinality.MULTIPLE) - public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, Map<String, Object> properties) { + public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, Review Comment: @raducotescu TBH I don't understand this. Why are the defaults not injected in the bind method? The spec says > An event method can take one or more parameters.An event method can take one or more parameters. ... > Map - An unmodifiable Map containing the service properties of the bound service. This Map must additionally implement Comparable with the compareTo method comparing service property maps using the same ordering as ServiceReference.compareTo based upon service ranking and service id. (https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-method.injection) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org