stefanseifert commented on code in PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/10#discussion_r1112205272
##########
src/main/java/org/apache/sling/testing/mock/jcr/MockNodeType.java:
##########
@@ -54,6 +54,12 @@ public boolean hasOrderableChildNodes() {
// support only well-known built-in node type
return StringUtils.equals(getName(), JcrConstants.NT_UNSTRUCTURED);
}
+
+ @Override
+ public boolean isMixin() {
+ // if it has at least 1 supertype -> isMixin
+ return (getDeclaredSupertypes().length > 0);
Review Comment:
from my pov it's fine to move isMixin back to unsupported methods and remove
the implementation. it would require a bit more rework to make this working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
