[
https://issues.apache.org/jira/browse/SLING-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708413#comment-17708413
]
Konrad Windszus commented on SLING-11818:
-----------------------------------------
bq. First of all these dependencies are not used in the pom at all
Both {{osgi.core}} and {{osgi.cmpn}} are transitive dependencies of
{{org.apache.sling.testing.osgi-mock}}. If you don't manage the scope those
will end up in the compile classpath. Just look at the effective pom or the
output of {{mvn dependency:build-classpath -DincludeScope=compile}}. Without
the dependency management to explicitly manage the scope of those, the compile
classpath is unnecessarily big.
bq. second as I wrote it broke tooling -
You initially wrote "buggy dependency management section" which I disagree
with. Seems that the tooling you are referring to just cannot properly
calculate the effective pom. That needs to be fixed. Can you describe in a
dedicated JIRA issue what exactly the problem was?
bq. it is ironic that you ask for a PR where your change which broke it was
done without a PR
Yes, you are right, my changes should also have been introduced through a PR.
But they didn't revert any changes, while yours did. In any case the code
quality benefits from PRs so let's do that even more often in the future.
> Update to Sling Parent POM 48 broke api generation
> --------------------------------------------------
>
> Key: SLING-11818
> URL: https://issues.apache.org/jira/browse/SLING-11818
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Base 3.1.12
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Priority: Major
> Fix For: JCR Base 3.1.14
>
>
> This commit
> [https://github.com/apache/sling-org-apache-sling-jcr-base/commit/97ea7f527040b1bcb0f7f9888a4c599ca91f58cb]
> added a buggy dependency management section to the pom without any versions.
> This confuses other tools like the slingfeature maven plugin.
> The whole dependency management section is not needed and can simply be
> removed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
