kwin commented on code in PR #165:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1176313939
##########
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java:
##########
@@ -145,6 +146,9 @@ public final class
ContentPackage2FeatureModelConverterLauncher implements Runna
@Option(names = { "--sling-initial-content-policy" }, description =
"Determines what to do with Sling-Initial-Content found in embedded bundles.
Valid values: ${COMPLETION-CANDIDATES}.", required = false, showDefaultValue =
Visibility.ALWAYS)
private SlingInitialContentPolicy slingInitialContentPolicy =
SlingInitialContentPolicy.KEEP;
+
+ @Option(names = { "--runmode-policy" }, description = "Determines how to
determine the final runmode of an artifac. Valid values:
${COMPLETION-CANDIDATES}.", required = false, showDefaultValue =
Visibility.ALWAYS)
Review Comment:
rather `--run-mode-policy`. Also I still don't see the readme in
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/README.md#run-modes
and
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/README.md#the-cli-tool
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
