[GitHub] [sling-org-apache-sling-starter] kwin commented on a diff in pull request #153: SLING-11718 - Add Jakarta JSON support to the Sling Starter

[via GitHub]

kwin commented on code in PR #153:
URL: 
https://github.com/apache/sling-org-apache-sling-starter/pull/153#discussion_r1176327384


##########
src/main/features/boot.json:
##########
@@ -84,6 +84,14 @@
             "id":"org.apache.felix:org.apache.felix.log:1.2.6",
             "start-order":"1"
         },
+        {
+            "id":"org.eclipse.parsson:jakarta.json:1.1.1",

Review Comment:
   Ok, it seems that basically `org.eclipse.parsson:jakarta.json` is an 
aggregate of `org.eclipse.parsson:parsson:1.1.1` and 
`jakarta.json:jakarta.json-api`. I think we should rather rely on the 
individual bundles instead of the aggregate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org