cziegeler commented on code in PR #96:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/96#discussion_r1188295311


##########
src/test/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImplTest.java:
##########
@@ -397,8 +397,8 @@ public void mapResourceWithVanityPathsURLTargetNoPath() {
         ExpectedMappings.existingResource("/vain-url-nopath")
             .singleMapping("/vain-url-nopath")
             .singleMappingWithRequest("/app/vain-url-nopath")
-            .allMappings("/vain-url-nopath", "")
-            .allMappingsWithRequest("/app/vain-url-nopath", "")

Review Comment:
   I would prefer not changing the behaviour and maybe just update the javadocs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to