kwin commented on code in PR #19:
URL:
https://github.com/apache/sling-tooling-jenkins/pull/19#discussion_r1358030566
##########
vars/slingOsgiBundleBuild.groovy:
##########
@@ -189,6 +189,8 @@ def defineStage(def globalConfig, def jobConfig, def
jdkVersion, def operatingSy
}
// calculate coverage with jacoco (for subsequent evaluation by
SonarQube)
additionalMavenParams = "${additionalMavenParams} -Pjacoco-report"
+ // generate javadocs to detect illegal javadoc markup in sources
+ additionalMavenParams = "javadoc:javadoc ${additionalMavenParams}"
Review Comment:
can you extend variable `goal` instead? That way the order is implicitly
correct and we have a better separation between goal and other parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
