adamcin commented on PR #31:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1762169343

   > this is taking good shape, thanks for all the work you put into this. is 
anything functional missing from your side? it would be good to update the 
documentation PR and the code samples in this PR to reflect the latest changes, 
and document the possibilities and different use cases.
   > 
   > also have a look at the code smells reported by sonarcloud: 
https://sonarcloud.io/summary/new_code?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=31
   
   @stefanseifert I think this is complete. I've updated the site-docs as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to