[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784105#comment-17784105 ]
Konrad Windszus edited comment on SLING-12131 at 11/8/23 3:53 PM: ------------------------------------------------------------------ Testing dependencies are never transitive and therefore should not affect simple consumers of any Sling bundles! As long as JUnit4 tests execute fine just within the Sling project I agree with [~jsedding] that other things are much more important than changing the runner. I already made the experience that running both JUnit4 and 5 side by side is not always properly detected by maven-surefire-plugin, so this may be some more effort. But this is open source, everyone is invited to propose PRs to migrate existing Sling modules. was (Author: kwin): Testing dependencies are never transitive and therefore should not affect simple consumers of any Sling bundles! As long as JUnit4 tests execute fine just within the Sling project I agree with [~jsedding] that other things are much more important. I already made some experience that running both JUnit4 and 5 side by side is not always properly detected by maven-surefire-plugin, so this may be some more effort. But this is open source, everyone is invited to propose PRs to migrate existing Sling modules. > Update sling-parent pom.xml to include JUnit5 dependencies > ---------------------------------------------------------- > > Key: SLING-12131 > URL: https://issues.apache.org/jira/browse/SLING-12131 > Project: Sling > Issue Type: Task > Reporter: Rob McDougall > Priority: Major > > JUnit4 is in maintenance mode (no updates in the last 2 years and then only > security fixes). I think updating projects to JUnit5 should be encouraged. > I am thinking this should be a relatively easy change of adding the > junit-jupiter and junit-vintage-engine into the Dependency Management section > of the sling-parent. > Once this is done, individual projects could switch to the vintage-engine (at > the very least) or move to jupiter by switching the dependency in their > project pom. > Some day down the road, the JUnit 4 dependencies could be removed. Projects > that have not updated to JUnit5 (vintage or jupiter) by that time are likely > no longer maintained. -- This message was sent by Atlassian Jira (v8.20.10#820010)