anchela commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1388024166
##########
src/test/java/org/apache/sling/jcr/repoinit/GeneralAclTest.java:
##########
@@ -270,9 +270,9 @@ private void verifyRegisterNamespace(String username,
String prefix, String uri,
try {
userSession = U.loginService(username);
userSession.getWorkspace().getNamespaceRegistry().registerNamespace(prefix,
uri);
- assertTrue("Register namespace succeeded " + prefix + uri,
successExpected);
+ assertTrue("Register namespace succeeded " + prefix + " " + uri,
successExpected);
} catch (RepositoryException e) {
- assertTrue("Error registering namespace " + prefix + uri + " " +
e.getMessage(), !successExpected);
+ assertFalse("Error registering namespace " + prefix + " " + uri +
" " + e.getMessage(), successExpected);
Review Comment:
but unrelated to the task at hand, right?
i really would like changes to a particular bug or improvement to be limited
to the task at hand.... for me just looking at the diff it's just harder to
figure out why something was change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
