henrykuijpers commented on code in PR #39:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/39#discussion_r1403735663
##########
src/main/java/org/apache/sling/jcr/resource/api/JcrResourceChange.java:
##########
@@ -16,27 +16,37 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.sling.jcr.resource.internal;
+package org.apache.sling.jcr.resource.api;
import org.apache.sling.api.resource.observation.ResourceChange;
/**
- * Extension of {@code ResourceChange} to support user id (if available)
+ * Extension of {@code ResourceChange} to support user id and user data (if
available)
*/
-public class JcrResourceChange extends ResourceChange {
+public final class JcrResourceChange extends ResourceChange {
Review Comment:
It could contain nice "ootb" behavior and as an implementer it could be nice
to reuse it and/or to extend it. We've done this a lot with various classes and
it's always unfortunate when they are in internal packages or when they are
final. (Devil's advocate speaking here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
