enapps-enorman commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/26#issuecomment-1833087468
> I suggest that we log a new SLING ticket for that. This would require some additional work that is outside the scope of this ticket. @pat-lego I'm not opposed to further refactoring in another ticket. I was just hoping to not have merge while there are known failures in the quality gate rules. If we can get the quality gate checking to be green before merging it would be better. That would mean getting the code coverage on the changed lines from 53.3% to greater than 80%. The current report shows that the testing does not exercise 3 lines on new code and 4 conditions on new code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
